fix: use logical OR in postgres connection drain loop#1887
Open
LautaroPetaccio wants to merge 2 commits into
Open
fix: use logical OR in postgres connection drain loop#1887LautaroPetaccio wants to merge 2 commits into
LautaroPetaccio wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The connection drain loop in
postgres.tsused bitwise OR (|) instead of logical OR (||) to check if the pool still had active connections:Bitwise OR on integers happens to produce the same truthiness as logical OR for non-negative values (returns 0 only when all are 0), so this worked by accident. Changed to logical OR with proper parentheses for correctness and clarity.
Test plan