Skip to content

fix: preserve original error info on unexpected deploy failures #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LautaroPetaccio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve original error info on unexpected deploy failures #1925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions content/src/logic/deployment-service/component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,12 @@ export function createDeploymentService(

// TODO: review this
return storeResult.auditInfoComplete.localTimestamp || Date.now()
} catch (error) {
} catch (error: any) {
logger.error(`There was an error deploying the entity: ${error}`, { entityId })
const name = error?.name ?? 'Error'
const message = error?.message ?? 'unknown error'
return InvalidResult({
errors: [`There was an error deploying the entity`]
errors: [`There was an error deploying the entity: ${name}: ${message}`]
})
} finally {
components.pointerLockManager.release(entity.type, entity.pointers)
Expand Down
Loading