Merged
Conversation
Signed-off-by: Nikolay Mitrofanov <nikolay.mitrofanov@flant.com>
Signed-off-by: Nikolay Mitrofanov <nikolay.mitrofanov@flant.com>
name212
force-pushed
the
move-envs-extractor-to-utls
branch
from
e22e4b1 to
f9096dc
Compare
Signed-off-by: Nikolay Mitrofanov <nikolay.mitrofanov@flant.com>
Signed-off-by: Nikolay Mitrofanov <nikolay.mitrofanov@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move envs extractor to
pkg/utils/envpackage. It needs to use in kube provider alsoAdd
ExtractAllmethod to parse flags without call typed methodsInterpret
falsenonone0(in all string case) env value as falseMove getting home dir and current user name to
pkg/utils/defaultspackage. It needs to use in kube provider also