Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,30 @@ import (
"context"
"errors"
"fmt"
"slices"

corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/validation"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"

"github.com/deckhouse/deckhouse/pkg/log"
commonvmop "github.com/deckhouse/virtualization-controller/pkg/common/vmop"
"github.com/deckhouse/virtualization-controller/pkg/controller/validator"
"github.com/deckhouse/virtualization-controller/pkg/featuregates"
"github.com/deckhouse/virtualization-controller/pkg/version"
"github.com/deckhouse/virtualization/api/core/v1alpha2"
)

func NewValidator(c client.Client, log *log.Logger) admission.CustomValidator {
return validator.NewValidator[*v1alpha2.VirtualMachineOperation](log.
With("controller", "vmop-controller").
With("webhook", "validation"),
).WithCreateValidators(&nodeSelectorValidator{})
).WithCreateValidators(
&nodeSelectorValidator{},
&localStorageMigrationValidator{client: c},
)
}

type nodeSelectorValidator struct{}
Expand Down Expand Up @@ -68,3 +76,51 @@ func (n *nodeSelectorValidator) validateNodeSelector(nodeSelector map[string]str

return nil
}

type localStorageMigrationValidator struct {
client client.Client
}

func (v *localStorageMigrationValidator) ValidateCreate(ctx context.Context, vmop *v1alpha2.VirtualMachineOperation) (admission.Warnings, error) {
if version.GetEdition() != version.EditionCE {
return nil, nil
}

if !commonvmop.IsMigration(vmop) {
return nil, nil
}

vm := &v1alpha2.VirtualMachine{}
err := v.client.Get(ctx, types.NamespacedName{Name: vmop.Spec.VirtualMachine, Namespace: vmop.Namespace}, vm)
if err != nil {
return nil, fmt.Errorf("failed to get VirtualMachine: %w", err)
}

for _, bda := range vm.Status.BlockDeviceRefs {
if bda.Kind != v1alpha2.DiskDevice {
continue
}

vd := &v1alpha2.VirtualDisk{}
err := v.client.Get(ctx, types.NamespacedName{Name: bda.Name, Namespace: vmop.Namespace}, vd)
if err != nil {
return nil, fmt.Errorf("failed to get VirtualDisk %s: %w", bda.Name, err)
}

if vd.Status.Target.PersistentVolumeClaim == "" {
continue
}

pvc := &corev1.PersistentVolumeClaim{}
err = v.client.Get(ctx, types.NamespacedName{Name: vd.Status.Target.PersistentVolumeClaim, Namespace: vmop.Namespace}, pvc)
if err != nil {
return nil, fmt.Errorf("failed to get PersistentVolumeClaim %s: %w", vd.Status.Target.PersistentVolumeClaim, err)
}

if !slices.Contains(pvc.Spec.AccessModes, corev1.ReadWriteMany) {
return nil, fmt.Errorf("migration of virtual machines with local (RWO) virtual disks is available only in the Enterprise Edition (EE)")
}
}

return nil, nil
}
Loading