Skip to content

test hotplugged disks #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
loktev-d wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test hotplugged disks #1955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d80535
wip
loktev-d Feb 4, 2026
d2be840
wip
loktev-d Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api/core/v1alpha2/virtual_machine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ type VirtualMachineSpec struct {
Memory MemorySpec `json:"memory"`
// List of block devices that can be mounted by disks belonging to the virtual machine.
// The order of booting is determined by the order in the list.
// +kubebuilder:validation:MinItems:=1
// +kubebuilder:validation:MaxItems:=16
BlockDeviceRefs []BlockDeviceSpecRef `json:"blockDeviceRefs"`
Provisioning *Provisioning `json:"provisioning,omitempty"`
Expand Down
2 changes: 0 additions & 2 deletions crds/virtualmachines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ spec:
- virtualMachineClassName
- cpu
- memory
- blockDeviceRefs
properties:
provisioning:
description: |
Expand Down Expand Up @@ -929,7 +928,6 @@ spec:

blockDeviceRefs:
type: array
minItems: 1
maxItems: 16
description: |
List of block devices connected to the VM.
Expand Down
1 change: 1 addition & 0 deletions images/virtualization-artifact/pkg/apiserver/registry/vm/rest/add_volume.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ func (r AddVolumeREST) genMutateRequestHook(opts *subresources.VirtualMachineAdd
Name: opts.Name,
DiskDevice: dd,
Serial: serial,
BootOrder: ptr.To(uint(1)),
ErrorPolicy: ptr.To(virtv1.DiskErrorPolicyReport),
},
}
Expand Down
Loading