feat: add app registry for framework auto-discovery#18
Open
JonasJesus42 wants to merge 2 commits intomainfrom
Open
feat: add app registry for framework auto-discovery#18JonasJesus42 wants to merge 2 commits intomainfrom
JonasJesus42 wants to merge 2 commits intomainfrom
Conversation
Export a registry mapping CMS block keys to app module loaders, so @decocms/start can import it instead of hardcoding known apps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:7">
P1: This export points to a file that the package whitelist does not publish, so `@decocms/apps/registry` will fail to resolve for consumers.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry.tsthat maps CMS block keys to app module loaders@decocms/apps/registryso@decocms/startcan import it instead of hardcoding known apps inAPP_MODSdeco-websitealongside existing vtex, shopify, and resend appsCompanion change needed in
@decocms/startReplace the hardcoded
APP_MODSinsrc/apps/autoconfig.tswith:Test plan
npm testpasses (225 tests)biome checkhas no errors@decocms/startto consume the registry🤖 Generated with Claude Code
Summary by cubic
Adds a central app registry exported as
@decocms/apps/registrythat maps CMS block keys to lazy-loaded modules for auto-discovery in@decocms/start. Addsdeco-websiteand ensures the registry is included in package exports and published viafiles.Migration
@decocms/start, replace the hardcodedAPP_MODSwith:import { apps as APP_MODS } from '@decocms/apps/registry'.Bug Fixes
registry.tsinpackage.jsonfilesso@decocms/apps/registryresolves after publish.Written for commit c819451. Summary will update on new commits.