fix: run section loaders for nested sections recursively

[JonasJesus42]

Summary

• runSingleSectionLoader now recursively detects nested sections in resolved props ({ Component, props } shape from normalizeNestedSections) and runs their registered loaders
• Fixes wrapper sections like BackgroundWrapper whose child sections (e.g. CategoryBanner) never had their loaders invoked
• Nested loaders run in parallel via Promise.all; leaf sections with no nested children incur zero extra allocation (same reference returned)

Test plan

• Verify a page with BackgroundWrapper > CategoryBanner renders the banner correctly without a site-level workaround
• Verify top-level section loaders still work as before (layout, cacheable, regular)
• Verify deeply nested sections (wrapper inside wrapper) also get their loaders run

🤖 Generated with Claude Code

---

Summary by cubic

Recursively run section loaders for nested sections found in resolved props to ensure child sections inside wrappers load their data and render correctly (e.g., BackgroundWrapper > CategoryBanner).

• Bug Fixes
  • runSingleSectionLoader now walks props to detect normalized nested sections ({ Component, props }) and runs their loaders.
  • Handles arrays and deep nesting; runs nested loaders in parallel with Promise.all.
  • Keeps existing layout/cacheable/regular behavior and error handling; leaf sections avoid extra allocations.

^{Written for commit c84d57c. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/cms/sectionLoaders.ts">

<violation number="1" location="src/cms/sectionLoaders.ts:355">
P2: `enrichNestedSections` only inspects direct prop values and array items, but `normalizeNestedSections` in resolve.ts produces `{ Component, props }` at arbitrary depths inside plain objects. Nested sections inside non-section objects (e.g. `props.config.banner`) will silently skip loader enrichment. Consider adding an `else if (typeof value === 'object')` branch that recurses into plain objects.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: enrichNestedSections only inspects direct prop values and array items, but normalizeNestedSections in resolve.ts produces { Component, props } at arbitrary depths inside plain objects. Nested sections inside non-section objects (e.g. props.config.banner) will silently skip loader enrichment. Consider adding an else if (typeof value === 'object') branch that recurses into plain objects.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/cms/sectionLoaders.ts, line 355:

<comment>`enrichNestedSections` only inspects direct prop values and array items, but `normalizeNestedSections` in resolve.ts produces `{ Component, props }` at arbitrary depths inside plain objects. Nested sections inside non-section objects (e.g. `props.config.banner`) will silently skip loader enrichment. Consider adding an `else if (typeof value === 'object')` branch that recurses into plain objects.</comment>

<file context>
@@ -266,38 +266,127 @@ export async function runSectionLoaders(
+        key: value.Component,
+      };
+      promises.push({ key, promise: runSingleSectionLoader(nested, request) });
+    } else if (Array.isArray(value)) {
+      for (let i = 0; i < value.length; i++) {
+        const item = value[i];
</file context>