fix(valkey): pass SentinelPassword to FailoverClient#4
Open
nicacioliveira wants to merge 1 commit intomainfrom
Open
fix(valkey): pass SentinelPassword to FailoverClient#4nicacioliveira wants to merge 1 commit intomainfrom
nicacioliveira wants to merge 1 commit intomainfrom
Conversation
The FailoverClient needs SentinelPassword to authenticate with Sentinel when auth is enabled (sentinel: true in Bitnami chart). Without it, the client fails with NOAUTH when discovering the master. Uses the same AdminPassword since the Bitnami chart configures Sentinel with the master password when sentinel auth is enabled. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SentinelPasswordtoredis.FailoverOptionsso the operator can authenticate with Sentinel whenauth.sentinel: trueis enabled in the Bitnami Valkey chartAdminPasswordsince the Bitnami chart configures Sentinel with the master passwordContext
Without this, the FailoverClient fails with
NOAUTH Authentication requiredwhen trying to discover the master via Sentinel. DirectNewSentinelClientconnections already pass the password correctly — only theFailoverClientwas missing it.Test plan
auth.sentinel: truein valkey-sites chart🤖 Generated with Claude Code
Summary by cubic
Pass
SentinelPasswordtoredis.FailoverOptionsin the failover client so it authenticates with Sentinel whenauth.sentinel: trueis enabled in the Bitnami Valkey chart, preventing NOAUTH during master discovery. ReuseAdminPasswordfor Sentinel auth since the chart configures Sentinel with the master password.Written for commit cd2f250. Summary will update on new commits.