refactor(sandbox): move freestyle runner and docker helpers into mesh-plugin-user-sandbox#3172
Merged
pedrofrxncx merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
…-plugin-user-sandbox Freestyle runner (daemon-script, runner, test) migrated from apps/mesh/src/sandbox/ to packages/mesh-plugin-user-sandbox/server/runner/freestyle/ so the plugin owns all sandbox runner implementations; apps/mesh imports it via the new ./runner/freestyle subpath export. Docker runner reorganized into its own directory: docker.ts -> docker/runner.ts, plus local-ingress and sweep moved alongside. Shared helpers (dev-server, handle, inflight, lock, preview-url) extracted into a shared/ directory so freestyle and docker runners stop duplicating them. RunnerKind type moved from runner/index.ts to runner/types.ts (single source of truth); plugin package.json gains ./runner/freestyle subpath export and migrates freestyle SDKs to optionalDependencies since docker-only deploys don't need them. No behavior change.
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Patch ( React with an emoji to override the release type:
Current version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure refactor — no behavior change. Split off from #3171 so the packaging work can land independently of the new Kubernetes runner.
apps/mesh/src/sandbox/topackages/mesh-plugin-user-sandbox/server/runner/freestyle/, exposed via a new./runner/freestylesubpath export. Freestyle SDKs are nowoptionalDependenciesso docker-only deploys don't pull them.docker.ts→docker/runner.ts, withlocal-ingressandsweepmoved alongside.dev-server,handle,inflight,lock,preview-url) extracted intoserver/runner/shared/so freestyle and docker stop duplicating them.RunnerKindmoved fromrunner/index.tstorunner/types.ts(single source of truth).Test plan
bun run checkpassesbun run lintpassesbun test packages/mesh-plugin-user-sandboxpassesbun run devboots and a docker-runner VM starts/stops cleanly🤖 Generated with Claude Code
Summary by cubic
Moved the Freestyle runner and Docker helpers into
mesh-plugin-user-sandboxand added a./runner/freestyleexport. No behavior change; docker‑only installs no longer pull Freestyle SDKs.Refactors
packages/mesh-plugin-user-sandbox/server/runner/freestyle/and exported via./runner/freestyle;apps/meshnow imports frommesh-plugin-user-sandbox/runner/freestyle.server/runner/docker/runner.tswithlocal-ingressandsweepcolocated; newserver/runner/docker/index.tsre-exports.dev-server,handle,inflight,lock,preview-url) extracted toserver/runner/shared/and used by both runners.RunnerKindmoved toserver/runner/types.tsas the single source of truth;./runnerexport surface updated to source Docker/local-ingress/sweep from the new paths.Dependencies
./runner/freestylesubpath export inpackages/mesh-plugin-user-sandbox/package.json.optionalDependencies(@freestyle-sh/with-bun,@freestyle-sh/with-deno,@freestyle-sh/with-nodejs,freestyle-sandboxes) so Docker-only deploys don’t install them.Written for commit 4ec33eb. Summary will update on new commits.