Skip to content

feat: DH-21756: Add ui.component memoization and selective re-rendering #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mofojed wants to merge 35 commits into
base: main
Choose a base branch
from
Open

feat: DH-21756: Add ui.component memoization and selective re-rendering #1296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
64bcaaf
Add component memoization implementation plan
mofojed Feb 6, 2026
e6c5340
WIP add ui.memo functionality
mofojed Feb 10, 2026
d567c3e
Fix unit tests
mofojed Feb 10, 2026
936a394
test: Add unit tests for ui.memo decorator
mofojed Feb 10, 2026
2e2421d
feat: Support @ui.memo without parentheses and add custom compare tests
mofojed Feb 10, 2026
76f152e
docs: Add documentation for @ui.memo component memoization
mofojed Feb 10, 2026
acdfe5a
refactor: Replace @ui.memo decorator with memo parameter on @ui.compo…
mofojed Feb 12, 2026
1505d9a
Change up how children are compared
mofojed Feb 12, 2026
0efaeaa
fix: Remove func param from second overload to fix Pylance error
mofojed Feb 12, 2026
0cc4008
Add plans for selective re-rendering, and tests that currently fail
mofojed Feb 12, 2026
71080e1
Selective re-rendering
mofojed Feb 13, 2026
944c04c
Fix up typing
mofojed Feb 13, 2026
2fccf01
Need to mark the RenderContext as dirty when importing state
mofojed Feb 13, 2026
4f88775
Update docs snapshots
mofojed Feb 13, 2026
e89d97e
Fix up typing of NodeType and PropsType
mofojed Feb 13, 2026
eb74bc0
Skip a test
mofojed Feb 13, 2026
b981c81
Cleanup based on review
mofojed Feb 18, 2026
e689dd5
Bit more consistency
mofojed Feb 18, 2026
2e02506
Update snapshots
mofojed Feb 24, 2026
56e8252
test: Fix test_memo RenderContext usage after rebase
mofojed Jun 11, 2026
5c24b1a
fix: Restore children-aware prop comparison for memoized components
mofojed Jun 11, 2026
f86f3b8
fix: Re-render URL consumers when URL changes under selective re-rend…
mofojed Jun 11, 2026
fd1996f
test: Add e2e test for ui.component memoization
mofojed Jun 12, 2026
2110998
refactor: extract shallow_equal helper for props memoization comparison
mofojed Jun 16, 2026
f5ce97d
docs: clarify memoization docs and add renderer test coverage
mofojed Jun 16, 2026
6b91695
Cleanup based on review
mofojed Jun 17, 2026
d584400
Merge remote-tracking branch 'origin/main' into ui-component-memoization
mofojed Jun 17, 2026
04f4607
test: Fix test_render_child_item_not_dirty to properly prime context …
mofojed Jun 17, 2026
21c8bd5
docs: Address PR review comments on memoizing-components.md
mofojed Jun 17, 2026
b4e89e5
Update doc snapshots
mofojed Jun 17, 2026
f674e12
Potential fix for pull request finding
mofojed Jun 17, 2026
9c04574
Clean up docstring
mofojed Jun 17, 2026
cebae43
Fix formatting
mofojed Jun 18, 2026
f820bdd
Apply suggestions from code review
mofojed Jun 18, 2026
c30b904
Clarify memoized render cache logic
mofojed Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ junit.xml

# Allow for local overrides of docker-compose.yml. https://docs.docker.com/compose/multiple-compose-files/merge/
docker-compose.override.yml
docker-compose.docs-snapshots.override.yml

# Ignore temporary files created during a release
releases/
Expand Down
Loading
Loading