-
Notifications
You must be signed in to change notification settings - Fork 18
fix: DH-21257: Check if panel parent is in root when opening #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f3d8c1a
fix: DH-21257: Check if panel parent is in root when opening
dgodinez-dh 2ddeb61
unit test
dgodinez-dh 2cf8002
attach topmost
dgodinez-dh 0379d81
refactor
dgodinez-dh 382e22f
merge latest
dgodinez-dh d4576c1
merge latest
dgodinez-dh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. a couple odd things when doing it like this:
The row layout not being respected is kind of "well we're trying our best", but the stack header not appearing seems to be a bug (you can't drag to move that item anymore... though it does re-appear if you drag another panel...).
Right now we're just adding the
parentif it's not attached; but I'm wondering if we should be re-adding the top most parent that isn't attached. A bit of a complication is that we would need to ensure it doesn't contain containers that have already been moved to somewhere else before re-attaching ... but I think would ultimately be more correct, and fix that header case. See if that's possible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to add top most parent. This also fixed the header issue.