fix: enable rewrite-launchers user service on first install#9
Closed
mhduiy wants to merge 1 commit intodeepin-community:masterfrom
Closed
fix: enable rewrite-launchers user service on first install#9mhduiy wants to merge 1 commit intodeepin-community:masterfrom
mhduiy wants to merge 1 commit intodeepin-community:masterfrom
Conversation
1. Removed 'set -e' to prevent script from exiting on non-critical errors 2. Added logic to enable xdg-desktop-portal-rewrite-launchers.service user service 3. Service is only enabled on first installation if not already enabled 4. Uses deb-systemd-helper for proper systemd integration 5. Checks DPKG_ROOT to ensure it's not running in a chroot environment Log: Enabled automatic activation of xdg-desktop-portal-rewrite- launchers service for Flatpak applications Influence: 1. Test Flatpak installation on fresh system to verify service gets enabled 2. Verify service is not re-enabled on package upgrades 3. Test in chroot environment to ensure service is not enabled 4. Check service status after installation: systemctl --user status xdg- desktop-portal-rewrite-launchers.service 5. Verify Flatpak applications can properly create desktop launchers 6. Test on systems where the service was previously disabled manually fix: 在首次安装时启用 rewrite-launchers 用户服务 1. 移除了 'set -e' 以防止脚本在非关键错误时退出 2. 添加了启用 xdg-desktop-portal-rewrite-launchers.service 用户服务的 逻辑 3. 服务仅在首次安装且尚未启用时才会被启用 4. 使用 deb-systemd-helper 进行正确的 systemd 集成 5. 检查 DPKG_ROOT 以确保不在 chroot 环境中运行 Log: 为 Flatpak 应用程序启用了 xdg-desktop-portal-rewrite-launchers 服务 的自动激活 Influence: 1. 在新系统上测试 Flatpak 安装，验证服务是否被启用 2. 验证在软件包升级时服务不会被重新启用 3. 在 chroot 环境中测试，确保服务不会被启用 4. 安装后检查服务状态：systemctl --user status xdg-desktop-portal- rewrite-launchers.service 5. 验证 Flatpak 应用程序能否正确创建桌面启动器 6. 在之前手动禁用该服务的系统上测试 PMS: BUG-339551
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Enabled automatic activation of xdg-desktop-portal-rewrite- launchers service for Flatpak applications
Influence:
fix: 在首次安装时启用 rewrite-launchers 用户服务
Log: 为 Flatpak 应用程序启用了 xdg-desktop-portal-rewrite-launchers 服务 的自动激活
Influence:
PMS: BUG-339551