Skip to content

fix(sql): Remove warning for unsupported Snowflake federated auth integration #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkislan merged 2 commits into from
Jan 15, 2026
+4 −11
Merged

fix(sql): Remove warning for unsupported Snowflake federated auth integration #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44ecf23
fix(sql): Remove warning for unsupported Snowflake federated auth int…
tkislan Jan 14, 2026
f242d03
Fix test
tkislan Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions deepnote_toolkit/sql/sql_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,9 +342,8 @@ def _handle_federated_auth_params(sql_alchemy_dict: dict[str, Any]) -> None:
"Invalid federated auth params, try updating toolkit version"
)
elif federated_auth.integrationType == "snowflake":
logger.warning(
"Snowflake federated auth is not supported yet, using the original connection URL"
)
# Snowflake federated auth is not supported yet, using the original connection URL
pass
else:
logger.error(
"Unsupported integration type: %s, try updating toolkit version",
Expand Down
10 changes: 2 additions & 8 deletions tests/unit/test_sql_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,10 +721,9 @@ def test_federated_auth_params_bigquery(self, mock_get_credentials):
"test-bigquery-access-token",
)

@mock.patch("deepnote_toolkit.sql.sql_execution.logger")
@mock.patch("deepnote_toolkit.sql.sql_execution._get_federated_auth_credentials")
def test_federated_auth_params_snowflake(self, mock_get_credentials, mock_logger):
"""Test that Snowflake federated auth logs a warning since it's not supported yet."""
def test_federated_auth_params_snowflake(self, mock_get_credentials):
"""Test that Snowflake federated auth doesn't do anything since it's not supported yet."""
from deepnote_toolkit.sql.sql_execution import (
FederatedAuthResponseData,
_handle_federated_auth_params,
Expand Down Expand Up @@ -757,11 +756,6 @@ def test_federated_auth_params_snowflake(self, mock_get_credentials, mock_logger
"test-snowflake-integration-id", "test-snowflake-auth-context-token"
)

# Verify a warning was logged
mock_logger.warning.assert_called_once_with(
"Snowflake federated auth is not supported yet, using the original connection URL"
)

# Verify params were NOT modified (snowflake is not supported yet)
self.assertEqual(sql_alchemy_dict["params"], original_params)

Expand Down