-
Notifications
You must be signed in to change notification settings - Fork 6
feat: remove python 3.9 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThis pull request removes Python 3.9 support and establishes Python 3.10 as the baseline across the project. CI (.circleci/config.yml) timeouts were increased for long-running steps and default Python versions/matrices updated to 3.10–3.13. Dockerfiles (ir/ir-base and python/conda) now default ARG PYTHON_VERSION to 3.10. The python3.9-specific Dockerfile was deleted. Documentation (python/readme.md) and supported tags were updated to reflect 3.10–3.13. Sequence Diagram(s)🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
7f0ca05 to
a106892
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@python/readme.md`:
- Around line 5-6: The Markdown heading "Supported Tags and Respective
Dockerfile Links" lacks a blank line after it; update the section by inserting a
single blank line immediately after the heading (i.e., after "# Supported Tags
and Respective Dockerfile Links") so the following list line with the tags
renders correctly and satisfies markdownlint.
- Around line 6-7: The referenced constraint files (URLs
https://tk.deepnote.com/constraints3.10.txt through constraints3.13.txt) are
missing and breaking builds; either deploy the missing constraint files at those
exact URLs or remove the --constraint references and README links that point to
them. Update python/readme.md to stop linking the nonexistent constraint URLs
and edit the Dockerfiles that reference these constraints (e.g., the Dockerfiles
in python/python and python/datascience/Dockerfile.datascience) to either (a)
remove the pip --constraint <url> flags or (b) replace them with valid hosted
constraint files; ensure the Dockerfile pip install lines and README entries
consistently reflect the chosen fix.
|
The check |
a6c9b80 to
7db4bfb
Compare
Summary by CodeRabbit
Chores
CI / Workflows
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.