Fix check_nvlink_connections called with None group#543
Open
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Open
Fix check_nvlink_connections called with None group#543yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
yurekami wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
Previously, check_nvlink_connections(group) was called before validating that group is not None. When users use the comm parameter instead of group, this would cause an AttributeError when trying to call group.size(). Moved the check inside the `if group is not None` block to only run the NVLink validation when a torch.distributed ProcessGroup is provided. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_nvlink_connections(group)was called before validating thatgroupis notNoneAttributeErrorwhen users used thecomm(mpi4py) parameter instead ofgroupProblem
When
group=Noneandcommis provided,check_nvlink_connectionswould fail trying to callgroup.size().Solution
Moved
check_nvlink_connections(group)inside theif group is not None:block.Changes
deep_ep/buffer.py- Moved NVLink check after None validationTest plan
group=None, comm=<mpi4py comm>and verify no AttributeErrorgroupand verify NVLink check still runs🤖 Generated with Claude Code