fix: ensure taskKind is always populated in getTaskQueueInfo#2
Open
deepshekhardas wants to merge 2 commits into
Open
fix: ensure taskKind is always populated in getTaskQueueInfo#2deepshekhardas wants to merge 2 commits into
deepshekhardas wants to merge 2 commits into
Conversation
Adds Sessions, a durable, run-aware stream primitive that scopes session.in / session.out records to a session (not a single run). Records survive run boundaries; reconnect-from-last-event-id is built in. Server foundation: - New /realtime/v1/sessions/:session/:io/append + /records routes - sessionRunManager + sessionsRepository + clickhouseSessionsRepository - mintRunToken for short-lived per-session tokens - s2Append retry-with-backoff + undici cause diagnostics - /api/v[12]/packets/* exempt from customer rate limits - BackgroundWorker schema gains taskKind enum (TASK, AGENT, SCHEDULED) - TaskRun.taskKind column + clickhouse 029_add_task_kind_to_task_runs_v2 Core types: - new sessionStreams, inputStreams, realtimeStreams packages in @trigger.dev/core - session-streams-api / realtime-streams-api surface Sessions dashboard UI (the primitive's own viewer): - /sessions index + detail routes - SessionsTable, SessionFilters, SessionStatus, CloseSessionDialog - AGENT/SCHEDULED filter in RunFilters + TaskTriggerSource Includes the sessions-primitive changeset.
- Fix early-return path when both queue override and TTL are provided - Fix no-worker-found fallback to query taskKind - Fix no-task-found fallback to include taskKind This ensures AGENT/SCHEDULED runs are correctly classified in ClickHouse.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| id: release | ||
| uses: softprops/action-gh-release@v1 | ||
| if: github.event_name == 'push' | ||
| uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the early-return path when both queue override and TTL are provided - previously AGENT/SCHEDULED runs were being misclassified as STANDARD in ClickHouse. Also fixes no-worker-found and no-task-found fallbacks to include taskKind.
Summary by cubic
Ensures
getTaskQueueInfoalways setstaskKind, fixing misclassified AGENT/SCHEDULED runs as STANDARD in ClickHouse and improving fallbacks.taskKindis preserved.taskKindin “no worker found” and “no task found” fallbacks to maintain accurate ClickHouse classification.Written for commit 1ee2dd8. Summary will update on new commits.