Skip to content

fix(webapp): notification style updates#5

Open
deepshekhardas wants to merge 11 commits into
mainfrom
fix/pr-3553-notification
Open

fix(webapp): notification style updates#5
deepshekhardas wants to merge 11 commits into
mainfrom
fix/pr-3553-notification

Conversation

@deepshekhardas

@deepshekhardas deepshekhardas commented May 12, 2026

Copy link
Copy Markdown
Owner

This PR includes notification style improvements:\n- Label notification dismiss button for accessibility\n- Show notification dismiss button on keyboard focus\n- Sanitize notification action URL to block unsafe protocols\n- Fix CodeQL DOM text reinterpreted as HTML warning\n- Avoid nested interactive elements in notification card


Summary by cubic

Improves webapp notification cards for accessibility and safety. Labels and exposes the dismiss button on focus, sanitizes action URLs, and resolves a CodeQL warning.

  • Bug Fixes
    • Add accessible label for the dismiss button.
    • Show the dismiss button when the card is keyboard-focused.
    • Sanitize notification action URLs to block unsafe protocols.
    • Fix CodeQL “DOM text reinterpreted as HTML” warning.
    • Remove nested interactive elements inside the notification card.

Written for commit e0dd504. Summary will update on new commits.

id: release
uses: softprops/action-gh-release@v1
if: github.event_name == 'push'
uses: softprops/action-gh-release@b4309332981a82ec1c5618f44dd2e27cc8bfbfda # v3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants