Open
Conversation
Author
|
Looks like this breaks Python 2 ¯_(ツ)_/¯ |
jamespeacock
approved these changes
Sep 17, 2018
jamespeacock
left a comment
jamespeacock
left a comment
There was a problem hiding this comment.
These are the changes that I have been looking for in order to make this library Python3 compatible. Thank you for getting rid of types and switching to six!
|
It seems like your changes could be a fork for a REAL python 3 version of encrypted fields... |
|
@mlavin If you haven't discovered this on your own yet, you don't need this guy's package anymore as django-extensions 2.0.0 and above offers encrypted fields support. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds off of the previous WIP for Python 3 and uses a version of python-keyczar which supports Python 3. Everything seems to work correctly on Python 3.5 and Django 1.11 but admittedly I haven't tested other Django versions or Python 2.