Conversation
| "devDependencies": { | ||
| "assert": "1.1.1", | ||
| "mocha": "1.18.2", | ||
| "node-util": "0.0.1", |
There was a problem hiding this comment.
don't see this used anywhere
There was a problem hiding this comment.
https://github.com/defunctzombie/node-url/pull/30/files#diff-1dd241c4cd3fd1dd89c570cee98b79ddR24 you might need to hit load diff
|
This should be considered wip until there's a babel ES5 build |
|
@defunctzombie I've come up with a slightly nicer way of doing it over at: https://github.com/graingert/browser-libs-node/blob/master/webpack.config.babel.js This automatically builds a browser safe url module. |
|
@graingert Does that mean this PR is ready for review or is not relevant? |
|
This PR is important because it contains two breaking changes that node v7.x introduced :
So thank you for this, @graingert! But I was wondering what still needs to be done to get this merged ? Can I help ? |
|
I second that. What is the hold up here and is there anything that can help it along? |
Fixes #24.