tech-debt batch 2: type-checked ESLint + CI hygiene (#149/#160)#163
Merged
Conversation
added 2 commits
June 22, 2026 17:01
Add @typescript-eslint/eslint-plugin + parser (v7.18.0, matching the ESLint 8.57 / eslint-config-next 14.2.x era) as devDependencies and wire type-checked linting via an overrides block scoped to src/lib/** so the blast radius stays bounded. - no-floating-promises -> error - no-misused-promises -> error - no-explicit-any -> warn (deferred typing tracked in #152) parserOptions.project points at ./tsconfig.json so the type-aware rules run under next lint (and thus next build, which has no ignoreDuringBuilds). No floating/misused-promise errors surfaced in the existing src/lib code, so no scraper/scheduler behavior was changed. Closes #149
…n bumps (#160) - Switch the test and smoke-boot docker build steps to buildx with a shared type=gha cache (distinct scope=test / scope=smoke), keeping --load and the same targets/tags so the subsequent docker run/boot steps are unchanged. - Add @vitest/coverage-v8 (matching vitest 2.1.8), a test:coverage script, and a non-gating CI step that prints a pure-libs (src/lib/**) coverage summary to the job summary. No thresholds — report-only first (standards §1). - Bump the Node-20 GitHub Actions to their latest Node-24 majors: checkout v4->v7, setup-node v4->v6, setup-buildx-action v3->v4, build-push-action v6->v7, login-action v3->v4, metadata-action v5->v6. Out of scope (deferred to the operator staging/update path): the next/prisma/ playwright/recharts/react/eslint dependency bumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tech-debt batch 2 — tooling hardening (epic #161). No runtime/feature change; surfaces future debt automatically + speeds CI.
Closes #149, closes #160.
#149 — type-checked ESLint
@typescript-eslint/{eslint-plugin,parser}@7.18.0(v7 = the ESLint 8.57 /eslint-config-next14.2.x era).overridesblock scoped tosrc/lib/**enablesno-floating-promises(error),no-misused-promises(error),no-explicit-any(warn).next/core-web-vitalskept;next buildenforces the rules (noignoreDuringBuilds).await/voidadded, no behavior change, no suppressions. 28no-explicit-anywarnings remain (warnings;collect.tstyping is deferred to Scraper dedup + typed GraphQL (auth login-fill, collect.ts any cluster, shared date/err helpers) #152).#160 — CI hygiene (dependency bumps deferred)
test+smoke-bootnow usedocker buildxwith a shared GHA cache (distinctscope=test/scope=smoke,--loadpreserves the image for the run/boot steps). Targets/tags/assertions unchanged.@vitest/coverage-v8@2.1.8+ atest:coveragescript + a non-gatingif: always()step that prints thesrc/lib/**coverage summary to the job summary. No thresholds → cannot fail CI. (Pure libs are high:series.ts100%,prediction.ts96.9%.)checkout@v7,setup-node@v6,setup-buildx-action@v4,build-push-action@v7,login-action@v4,metadata-action@v6— all confirmed to exist + target Node 24 (the prior actions logged a Node-20 deprecation warning).Verification (local, CI path)