Skip to content

hotfix: IntervalHeatmap null-payload render crash (#150 regression) #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delabrcd merged 1 commit into from
Jun 22, 2026
Merged

hotfix: IntervalHeatmap null-payload render crash (#150 regression) #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 28 additions & 19 deletions app/src/components/widgets/IntervalHeatmap.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,26 +125,35 @@ export function IntervalHeatmap({
</span>
}
>
<>
{/* Peak-demand readout caption (#77): value + when. Hidden if no peak. */}
{peakReadout && (
<div className="mb-1 shrink-0 text-xs text-slate-400">
<span className="font-medium text-slate-200">{peakReadout}</span>
{/* #150 regression fix: `children` is evaluated EAGERLY by React when
IntervalHeatmap renders — BEFORE IntervalWidgetBody decides to show the
loading skeleton. During the loading tick useIntervalPayload returns
payload === null, so dereferencing payload.grid here would throw an
unguarded render-time TypeError and take the WHOLE dashboard down. Gate
the populated subtree on `payload &&` so children is falsy until the
payload exists; IntervalWidgetBody renders its skeleton/empty meanwhile. */}
{payload && (
<>
{/* Peak-demand readout caption (#77): value + when. Hidden if no peak. */}
{peakReadout && (
<div className="mb-1 shrink-0 text-xs text-slate-400">
<span className="font-medium text-slate-200">{peakReadout}</span>
</div>
)}
{/* The grid fills the remaining height. HeatmapViz draws a scalable SVG
inside a box of the height we pass; in the fill cell we let it take
the flex remainder via a min-h-0 flex-1 wrapper. We pass the
SERVER-computed grid + rowLabels (no client re-aggregation). */}
<div className="min-h-0 flex-1">
<HeatmapViz
spec={spec}
grid={payload.grid}
rowLabels={payload.rowLabels}
height={pxHeight ?? 260}
/>
</div>
)}
{/* The grid fills the remaining height. HeatmapViz draws a scalable SVG
inside a box of the height we pass; in the fill cell we let it take
the flex remainder via a min-h-0 flex-1 wrapper. We pass the
SERVER-computed grid + rowLabels (no client re-aggregation). */}
<div className="min-h-0 flex-1">
<HeatmapViz
spec={spec}
grid={payload!.grid}
rowLabels={payload!.rowLabels}
height={pxHeight ?? 260}
/>
</div>
</>
</>
)}
</IntervalWidgetBody>
);
};
Expand Down
Loading