trim confusing load.op weight keys from config.yaml dumps#118
Merged
Conversation
Config dumps include merged extension defaults, which made CreateLoad and MixedLoad hard to distinguish in config.yaml. Apply step-type-aware trimming at serialization time so MixedLoad keeps load.op.weights while non-mixed steps keep scalar load.op.weight and drop mixed-only maps. Also cover guard paths with unit tests and keep weighted sub-step config logging consistent with the same serializer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigUtilto reduce confusingload.opkeys inconfig.yamlMixedLoadkeepsload.op.weightsand drops scalarload.op.weightMixedLoadkeeps scalarload.op.weight, dropsload.op.weights, and removes legacy mixed-style map values underload.op.weightLoadStepBasewhen serializing config dumpsConfigUtilTestcoverage for mixed/non-mixed behavior plus guard-return paths