Add collection count validation in NetDataReaderExtension#100
Open
Riryan wants to merge 2 commits into
Open
Conversation
Added validation for collection count in GetArrayExtension, GetArrayObject, and GetList methods. Introduced a constant to limit maximum collection size.
johnmoney
requested changes
May 26, 2026
Contributor
johnmoney
left a comment
johnmoney
left a comment
There was a problem hiding this comment.
This appears to remove:
///Read a quantized Vector3 from the reader, the vector is quantized into integers based on the cell size and compression mode, which determines how many bits are used for each component.
public static Vector3 GetQuantizedVector3(this NetDataReader reader, ushort cellSize, out int compressionMode)
{
Is this intentional? Also please pull request against develop.
Collaborator
Author
|
no access |
Contributor
|
On MmoKitCE, you should be able to switch to develop branch. Let me know if this is not the case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation for collection count in GetArrayExtension, GetArrayObject, and GetList methods. Introduced a constant to limit maximum collection size.