fix(windows): normalize_path - strip trailing spaces and dots#21
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to use Rust edition 2024 and toolchain 1.90.0, while adding support for Windows-specific path normalization that strips trailing dots and spaces from path components. The changes leverage new Rust 2024 features such as let chains in if conditions.
- Updates Rust toolchain from 1.86.0 to 1.90.0 and edition from 2021 to 2024
- Implements Windows path normalization to strip trailing dots and spaces
- Refactors conditional logic using Rust 2024's
letchain syntax
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lib.rs | Adds Windows path component normalization logic, refactors nested conditionals to use let chains, reorders imports alphabetically, and adds test cases for trailing dots/spaces |
| src/fs.rs | Reorders imports to follow alphabetical convention |
| rust-toolchain.toml | Updates Rust toolchain version from 1.86.0 to 1.90.0 |
| Cargo.toml | Updates Rust edition from 2021 to 2024 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows strips trailing spaces and dots.