fix: add rerun-if-changed to avoid unnecessary rebuilds#1
Merged
littledivy merged 3 commits intodenoland:mainfrom Mar 3, 2026
Merged
fix: add rerun-if-changed to avoid unnecessary rebuilds#1littledivy merged 3 commits intodenoland:mainfrom
littledivy merged 3 commits intodenoland:mainfrom
Conversation
The build script was missing cargo:rerun-if-changed directives, causing Cargo to rerun it on every build. Additionally, bindgen's CargoCallbacks was emitting rerun-if-changed for generated headers in OUT_DIR (whose path changes between builds) and system headers. Fixed by: 1. Adding explicit rerun-if-changed for all source files, headers, and template files 2. Removing CargoCallbacks from bindgen since we now manually track all relevant files
nathanwhit
approved these changes
Mar 3, 2026
littledivy
reviewed
Mar 3, 2026
Comment on lines
+41
to
+43
| // All source files | ||
| const SOURCES: &[&str] = &[ | ||
| "nghttp2/lib/sfparse.c", |
Member
There was a problem hiding this comment.
@kajukitli This is duplicate. See source files listed below
littledivy
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build script was missing
cargo:rerun-if-changeddirectives, causing Cargo to rerun it on every build. Additionally, bindgen'sCargoCallbackswas emitting rerun-if-changed for generated headers in OUT_DIR (whose path changes between builds) and system headers.Fixed by:
Verified locally: