fix(io/buffer): super and initialized prop

[kitsonk]

This gets rid of the error messages like the following when using io/buffer.ts under tsc directly via dnt:

TS2376: A 'super' call must be the first statement in the constructor when a class contains initialized properties, parameter properties, or private identifiers.

While this is being fixed in future version of TypeScript, it is a limitation that is easy to work around and allows people to use the std lib via dnt without type errors.

[kt3k]

LGTM

I was actually seeing the same error while using dnt

[kt3k]

@kitsonk I'm in favor of this change, but I'm not sure why this is ok in std and causes type error when using dnt transformation. Can this be somehow tested in std's CI?

[kitsonk]

@kt3k no, because it only occurs when using tsc directly and not targeting esnext. The fix is in TypeScript 4.6, and this is the PR that fixed it: microsoft/TypeScript#29374. You cannot force Deno to typecheck in non-esnext mode. The only way to manifest this would be to run some sort of process the converts everything via dnt to "node" code and then runs tsc against it, and I see that seperate to this PR if such a thing is desired.

[kitsonk]

I

@kitsonk I'm in favor of this change, but I'm not sure why this is ok in std and causes type error when using dnt transformation. Can this be somehow tested in std's CI?

I opened #1918 to cover this.

[kt3k]

Thanks for the explanation and creating the issue!

microsoft/TypeScript#29374.

Oh, that birthday cake PR!