feat(http/unstable): add RFC 9421 message signatures#7039
Open
tomas-zijdemans wants to merge 12 commits intodenoland:mainfrom
Open
feat(http/unstable): add RFC 9421 message signatures#7039tomas-zijdemans wants to merge 12 commits intodenoland:mainfrom
tomas-zijdemans wants to merge 12 commits intodenoland:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7039 +/- ##
==========================================
+ Coverage 94.43% 94.47% +0.04%
==========================================
Files 630 631 +1
Lines 50566 51170 +604
Branches 8969 9164 +195
==========================================
+ Hits 47750 48345 +595
- Misses 2247 2249 +2
- Partials 569 576 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartlomieju
requested changes
Apr 10, 2026
Member
bartlomieju
left a comment
There was a problem hiding this comment.
Thanks for the thorough implementation! A few things to address:
badge.svg changes don't belong in this PR — The reformatting of the SVG is unrelated to message signatures. Please drop it from the branch (or submit separately).
Contributor
Author
|
T%hanks for the feedback!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HTTP Message Signatures (RFC 9421) for signing and verifying HTTP requests and responses. Builds on the structured fields module (RFC 8941) already in std.
Coverage is as good as I can get it. There are a few lines of unreachable code.