Feat: replace em dash with --#5125
Merged
Merged
Conversation
Contributor
|
This has no ending. Why limit to only one character? If one inputs garbage, it is the own fault. I dislike this very special use case. |
w0rp
approved these changes
May 12, 2026
Member
w0rp
left a comment
w0rp
left a comment
There was a problem hiding this comment.
Nice to see someone submitting a simple fixer function.
Cheers! 🍻
Member
You can not use the function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLMs like to use em dash for no reason. I don't like non-ascii character in my text files, so I made a fixer to convert them from em dash to regular old
--which latex and markdown treat as EM dashes. Added tests. Yes some of this code was was partially created by claude.Naming is the hard part, definitely open to renames.
no_emdashascii_emdashreplace_emdashem_dashoremdash? etc.It might be argued there are quite a few annoying unicodes that could be replaced, who really wants a 🤗 in their C++ code?