編集画面にReferencePropertyEditorを表示タイプ UNIQUE で配置した場合の不具合修正#1979
Open
xlei-duoce wants to merge 4 commits intomasterfrom
Open
編集画面にReferencePropertyEditorを表示タイプ UNIQUE で配置した場合の不具合修正#1979xlei-duoce wants to merge 4 commits intomasterfrom
xlei-duoce wants to merge 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
編集画面で ReferencePropertyEditor を表示タイプ UNIQUE で配置した際に発生していた不具合（モーダル起動トリガーのクリックイベント多重バインド起因と思われる挙動）を抑止するため、modalWindow のクリックイベント登録を名前空間付きで再登録するようにしたPRです。
Changes:
modalWindowのクリックハンドラをclick.modalWindowの名前空間付きイベントとして登録- 再初期化時に既存の
click.modalWindowをoffしてからonすることで多重登録を防止
iplass-gem/src/main/resources/META-INF/resources/scripts/gem/functions.js
Outdated
Show resolved
Hide resolved
iplass-gem/src/main/resources/META-INF/resources/scripts/gem/functions.js
Outdated
Show resolved
Hide resolved
iplass-gem/src/main/resources/META-INF/resources/scripts/gem/skin/flat/design.js
Outdated
Show resolved
Hide resolved
iplass-gem/src/main/resources/META-INF/resources/scripts/gem/common.js
Outdated
Show resolved
Hide resolved
iplass-gem/src/main/resources/META-INF/resources/scripts/gem/common.js
Outdated
Show resolved
Hide resolved
iplass-gem/src/main/resources/META-INF/resources/scripts/gem/common.js
Outdated
Show resolved
Hide resolved
…ルできなくなる coplit指摘修正
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
fixes #1962
原因はdesign.js ですでに .modal-btn / .modal-lnk に対してmodalWindow() が初期化されています。functions.jsのrefUnique 側でも modalWindow() を呼び出しているため、click handler が二重登録されていました。その結果 overlayManager.addOverlay() が2回実行され、removeOverlay() とのバランスが崩れてスクロールが復元されなくなっていました。
対応：refUnique() から modalWindow() / subModalWindow() の初期化処理を削除し、UNIQUE 参照の業務ロジックのみを担当するように見直しました。
あわせて、動的に追加される UNIQUE 行については [common.js]側で .sel-btn / .ins-btn の modal 初期化を行うように変更し、多重初期化を防ぎつつ追加行でも正しくモーダルが開くようにしました。
動作確認・スクリーンショット（任意）
1962_テストエビデンス.xlsx
レビュー観点・補足情報（任意）