全文検索: バイナリファイルのパース時に最大文字数を超えた場合にコンテンツ内容が反映されない 対応#2009
Open
xlei-duoce wants to merge 2 commits intomasterfrom
Open
全文検索: バイナリファイルのパース時に最大文字数を超えた場合にコンテンツ内容が反映されない 対応#2009xlei-duoce wants to merge 2 commits intomasterfrom
xlei-duoce wants to merge 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
本PRは、全文検索のバイナリ解析（Apache Tika）において、最大文字数（writeLimit）超過時に例外で処理が中断されてコンテンツが反映されない問題（Issue #1970）に対応し、超過時は警告ログを出しつつ最大文字数までの抽出結果を返せるようにする変更です。
Changes:
SAXExceptionに加えてTikaExceptionもまとめて捕捉し、writeLimit 超過例外の場合は例外を握りつつ処理継続するように修正- Tika 1/2 系の writeLimit 超過例外を（クラス名で）判定できるよう定数化し、原因（cause）チェーンを辿って判定するヘルパーを追加
- WARNログをプレースホルダ形式に変更
...e/src/main/java/org/iplass/mtp/impl/fulltextsearch/parser/AbstractBinaryReferenceParser.java
Show resolved
Hide resolved
...e/src/main/java/org/iplass/mtp/impl/fulltextsearch/parser/AbstractBinaryReferenceParser.java
Show resolved
Hide resolved
...e/src/main/java/org/iplass/mtp/impl/fulltextsearch/parser/AbstractBinaryReferenceParser.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/iplass/mtp/impl/fulltextsearch/parser/AbstractBinaryReferenceParser.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
closes #1970
動作確認・スクリーンショット（任意）
1970_テストエビデンス.xlsx
レビュー観点・補足情報（任意）