Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
最新のフォーマットルールに合わせて、org.iplass.mtp.view.generic.editor 配下の各 *PropertyEditor に付与されている @Jsps/@Jsp アノテーション周りのコード整形(スペース付与・改行/インデント調整)を行うPRです。
Changes:
@Jsp(path=..., key=...)の引数表記をpath = ... , key = ...形式へ統一- 長い
@Jsp(...)宣言を複数行に分割して可読性を改善 - 既存のタブ/インデントをフォーマッタ出力に合わせて調整
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/TimestampPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/TimePropertyEditor.java | @Jsps 内 @Jsp の整形 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/StringPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/SelectPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/ReferencePropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/LongTextPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/IntegerPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/FloatPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/ExpressionPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/DecimalPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/DatePropertyEditor.java | @Jsps 内 @Jsp の整形 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/BooleanPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
| iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/AutoNumberPropertyEditor.java | @Jsps 内 @Jsp の整形・改行 |
iplass-gem/src/main/java/org/iplass/mtp/view/generic/editor/TimestampPropertyEditor.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
対応内容
最新のフォーマットルールを利用して、ソースをフォーマットする
closes #1988
動作確認・スクリーンショット(任意)
レビュー観点・補足情報(任意)