fix: AccordionTrigger className should append, not replace#2481
Open
Devil1716 wants to merge 1 commit into
Open
fix: AccordionTrigger className should append, not replace#2481Devil1716 wants to merge 1 commit into
Devil1716 wants to merge 1 commit into
Conversation
Apply the merged className after spreading trigger props so custom classes append instead of overwrite. Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccordionTrigger'sclassNamewas applied before{...trigger.props}, so the custom class overwroteAccordion__triggerclassNameafter the spread so bothAccordion__triggerand the consumer class are keptAccordion__trigger,ExpandCollapse__trigger, and the custom class are all presentCloses #2480
Test plan
node scripts/buildIconTypes.js && pnpm exec jest src/components/Accordion/index.test.tsx --no-coverage(21 passed)