feat(Notice): notice colors redesign#2489
Open
chornonoh-vova wants to merge 1 commit into
Open
Conversation
|
This looks great... can we swap the colors over to our new error/warning/success/neutral color set? In this context we'd use: Danger: Caution: Success (not sure if this exists): Info: Also, I know this is a bigger ask and perhaps we can talk about it, but it'd be great to add Material Symbols |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesigns the
Noticecomponent'sinfo,caution, anddangercolor variants to use softer, hand-tuned backgrounds paired with bolder, WCAG-compliant icon/border colors, and adds screenshot coverage for the component.