fix: ensure id included in supervisor child spec#31
Open
gf3 wants to merge 1 commit intoderekkraan:mainfrom
Open
fix: ensure id included in supervisor child spec#31gf3 wants to merge 1 commit intoderekkraan:mainfrom
id included in supervisor child spec#31gf3 wants to merge 1 commit intoderekkraan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
idis not set inchild_spec/1it defaults to__MODULE__which prevents more than one instance of HighlanderPG from running. Here is the output from the added test before the fix is applied:I also captured the log output from one of the tests to make it a little less noisy.