rspec setup#10
Open
AgIt0 wants to merge 2 commits into
Open
Conversation
Owner
There was a problem hiding this comment.
Is there a compelling reason to do this here in install.sh instead of in the john_henry:install Rake task that sets up the other gem files? Appending to a file is easy in bash, but when you need to insert at specific points it became hard, which is why that bit of code is all in the rake task.
Author
There was a problem hiding this comment.
lol you're completely right... sorry about that. The only thing is you run the install task after the initial commit, so the spec files won't be there, but I guess that's no biggie.
Owner
|
Question about where this PR has rspec being set up. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up rspec instead of test unit