Fix format import defaults (DJS#18151)#252
Open
suganya-sk wants to merge 3 commits intodeshaw:masterfrom
Open
Conversation
added 3 commits
June 6, 2023 05:52
The default formatting output of reformat-imports and jupyterlab-pyflyby have been modified to match that of tidy-imports. The new expected values of unittests were generated using tidy-imports, to ensure this match. Ref: DJS#18151 Reviewer: dhamodha
Collaborator
|
Checked a couple of failures. They seem to be failing because of the changes made as part of this PR |
dshivashankar1994
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note - I have a few tests failing locally on this but these tests are failing in master as well, so am assuming it's okay to raise a PR here.