Open
Conversation
…tching Add frontend/src/lib/pocketbase.ts with browser-singleton PocketBase instance, loginAsSuperuser(), fetchAllFeatures(), and fetchAllSurveys() functions.
- expandsliderList questions in surveysToCsv (same key pattern as selectList, was producing empty columns for all 23 slider items) - fix downloadCsv to append anchor to DOM before click and defer revokeObjectURL to avoid Firefox download failure - remove redundant isAdmin check in loginAsSuperuser (_superusers collection enforces superuser-only auth) - make FeatureRecord.feature optional to match defensive optional-chaining access at call site - add setLoading(false) in success path of LoginForm.onSubmit before calling onSuccess
- Fix CSV escaping to also quote cells containing carriage returns (\r) to prevent row corruption with Windows line endings in user text - Remove unused "loading" and "error" variants from ExportAuthState type since authState only transitions idle → authenticated
Restore missing isSuperuser guard in loginAsSuperuser per original plan.
- Add server-side filter for banned records in fetchAllFeatures to prevent banned content from being transmitted to the browser - Remove unreachable isSuperuser guard that was dead code after successful _superusers authWithPassword
- Remove redundant client-side isBanned filter (server-side filter already handles this) - Make FeatureRecord.feature.geometry optional to match actual usage with optional chaining
- Upgrade pocketbase SDK from 0.22.1 to 0.26.8 (latest) to better match server v0.36.5 - Add "use client" directive to pocketbase.ts to enforce client-only boundary at module level - Add re-auth button in data error state so users can return to login without page refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.