Address zizmor findings#19
Open
williammartin wants to merge 1 commit into
Open
Conversation
williammartin
commented
May 20, 2026
| if: ${{ github.event_name == 'issues' }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: gh issue edit ${{ github.event.issue.html_url }} --remove-label "needs-triage" || true |
Author
There was a problem hiding this comment.
I can't find an example where template injection is a real current issue, but:
- I think it makes sense to blanket follow this pattern rather than having to look closely
- There were some cases where a compromise of a maintainer could hide behaviour or change privileges
williammartin
commented
May 20, 2026
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| with: |
Author
There was a problem hiding this comment.
I couldn't find any place in cli/cli or desktop/desktop where not persisting credentials would be an issue.
williammartin
force-pushed
the
wm-address-zizmor-findings
branch
from
4c18866 to
538b734
Compare
williammartin
commented
May 20, 2026
| directory: "/" # Location of GitHub Actions workflow files | ||
| schedule: | ||
| interval: "weekly" | ||
| interval: "daily" |
Author
There was a problem hiding this comment.
This interval change isn't strictly needed, but it feels appropriate to have a sensible bound on the cooldown period since otherwise it could actually be 6+7 days.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows and Dependabot configuration to address zizmor audit findings by reducing potential injection surfaces in shell steps, tightening checkout credential persistence, and documenting/annotating intentional pull_request_target usage.
Changes:
- Move GitHub context and input interpolations out of
run:blocks intoenv:across multiple triage workflows. - Add
persist-credentials: falsetoactions/checkoutusages where checkout is only needed for reading files. - Document and annotate intentional
pull_request_targetusage in the Dependabot auto-merge workflow; adjust Dependabot update cadence.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/triage-unable-to-reproduce-comment.yml | Moves label values into env for safer shell usage. |
| .github/workflows/triage-remove-needs-triage.yml | Moves label lists/current label into env and uses consistent variable naming. |
| .github/workflows/triage-pr-requirements.yml | Centralizes commonly used labels into env for multiple gh-driven steps and messages. |
| .github/workflows/triage-label-incoming.yml | Moves removed/expected label names into env for safer comparisons. |
| .github/workflows/triage-detect-spam.yml | Disables persisted checkout credentials for read-only checkouts. |
| .github/workflows/triage-contributor-input-needed.yml | Moves event-derived values into env to avoid direct interpolation in shell logic. |
| .github/workflows/triage-close-invalid.yml | Quotes URLs by assigning them to env variables before passing to gh commands. |
| .github/workflows/codeql.yml | Disables persisted checkout credentials for the CodeQL job. |
| .github/workflows/auto-merge-dependabot.yml | Documents pull_request_target rationale and adds a zizmor ignore annotation. |
| .github/dependabot.yml | Changes update schedule to daily and adds a cooldown window. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 10/10 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When run with
zizmor --config "$HOME/.config/zizmor/config.yml"