Skip to content

Bump to node 24 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfreeman422 merged 3 commits into from
Apr 10, 2026
Merged

Bump to node 24 #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84fb219
Bumped to latest node
sfreeman422 Apr 9, 2026
b26d733
npm i
sfreeman422 Apr 9, 2026
45afbd8
Address all review comments: bookworm-slim build stage, @types/node 2…
Copilot Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ runs:
steps:
- uses: actions/setup-node@v4
with:
node-version: '20'
node-version-file: '.nvmrc'
- uses: actions/download-artifact@v4
with:
name: node-modules
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '24.14.1'
cache: 'npm'
- run: npm ci
- run: tar -czf node-modules.tar.gz node_modules
Expand Down Expand Up @@ -162,7 +162,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '24.14.1'
- name: Generate release metadata
run: |
PREVIOUS_RELEASE_SHA=$(git rev-parse HEAD^ 2>/dev/null || true) \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-frontend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '24.14.1'
cache: 'npm'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '24.14.1'

- name: Generate release metadata
run: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
24.14.1
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ mocker/

### Prerequisites

- **Node.js** 20+ (for backend and frontend development)
- **Node.js** 24 LTS (>=24.14.1, for backend and frontend development)
- **MySQL** 5.7+ (for storing messages, users, game state)
- **Slack workspace** (for bot integration)
- **Ngrok** (optional, for local tunneling during development)
Expand Down
25 changes: 17 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
"version": "1.0.0",
"description": "Mock your friends - Monorepo",
"private": true,
"engines": {
"node": ">=24.14.1 <25"
},
"workspaces": [
"packages/*"
],
Expand Down
4 changes: 2 additions & 2 deletions packages/backend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Before building, generate release metadata:
# PREVIOUS_RELEASE_SHA="$(git rev-parse HEAD^ 2>/dev/null || true)" \
# node packages/backend/scripts/write-release-metadata.js packages/backend/release-metadata.json
FROM node:20-alpine AS build
FROM node:24.14.1-bookworm-slim AS build
WORKDIR /usr/src/app

# Copy workspace and backend files required for compilation and minification.
Expand All @@ -22,7 +22,7 @@ RUN npm ci \
&& npm run build:prod -w @mocker/backend \
&& npm prune --omit=dev

FROM gcr.io/distroless/nodejs20-debian12:nonroot AS release
FROM gcr.io/distroless/nodejs24-debian13:nonroot AS release
ENV NODE_ENV=production \
PORT=80 \
IMAGE_DIR=/tmp/mocker-images
Expand Down
7 changes: 5 additions & 2 deletions packages/backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,17 @@
"version": "1.0.0",
"description": "Mock your friends - Backend API",
"main": "dist/index.js",
"engines": {
"node": ">=24.14.1 <25"
},
Comment on lines +6 to +8
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engines.node was bumped to Node 24, but @types/node is still pinned to a 20.x version in this package. This can cause type mismatches/missing Node 24 APIs in TS builds; update @types/node to a 24.x-compatible version (and regenerate the lockfile) to keep types aligned with the runtime target.

Copilot uses AI. Check for mistakes.
"scripts": {
"build": "tsc -p tsconfig.build.json",
"build:prod": "tsc -p tsconfig.prod.json",
"lint": "eslint --cache --cache-location ../../node_modules/.cache/eslint/backend/.eslintcache './**/*.{js,ts}'",
"lint:fix": "eslint --cache --cache-location ../../node_modules/.cache/eslint/backend/.eslintcache './**/*.{js,ts}' --quiet --fix",
"format:check": "prettier --cache --ignore-path ../../.prettierignore --check \"**/*.{ts,js,json,md,yml,yaml}\"",
"format:fix": "prettier --cache --ignore-path ../../.prettierignore --write \"**/*.{ts,js,json,md,yml,yaml}\"",
"minify": "esbuild dist/**.js dist/**/*.js --bundle --minify --target=node18 --platform=node --outdir=dist --allow-overwrite --packages=external --external:dist/shared/db/models/*",
"minify": "esbuild dist/**.js dist/**/*.js --bundle --minify --target=node24 --platform=node --outdir=dist --allow-overwrite --packages=external --external:dist/shared/db/models/*",
"start": "npm run start:dev",
"start:prod": "node dist/index.js",
"start:dev": "nodemon --watch 'src/**/*.ts' --ignore 'src/**/*.spec.ts' --exec 'ts-node' src/index.ts",
Expand Down Expand Up @@ -49,7 +52,7 @@
"@types/easy-table": "0.0.32",
"@types/express": "^4.17.21",
"@types/lolex": "^3.1.1",
"@types/node": "^20.19.37",
"@types/node": "^24.0.0",
"@types/node-cron": "^3.0.11",
"@types/sentiment": "^5.0.1",
"@types/supertest": "^7.2.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"description": "Mock your friends - Frontend",
"private": true,
"type": "module",
"engines": {
"node": ">=24.14.1 <25"
},
"scripts": {
"dev": "vite",
"build": "tsc -b && vite build",
Expand Down
Loading