Skip to content

Separate message for denied root #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SapuSeven wants to merge 2 commits into
base: 3.0beta
Choose a base branch
from
Open

Separate message for denied root #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09fbb9d
Added separate message for missing root permissions
SapuSeven Jan 25, 2018
625849b
Added separate message for missing root permissions
SapuSeven Jan 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions app/src/main/java/com/devadvance/rootcloak2/NativeRootDetection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ protected void onCreate(Bundle savedInstanceState) {
.setSharedPreferencesMode(MODE_WORLD_READABLE);
addPreferencesFromResource(R.xml.native_root_detection);
mPrefs = PreferenceManager.getDefaultSharedPreferences(this);

Preference uninstallLibrary = findPreference("uninstall_library");
uninstallLibrary.setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
@Override
Expand Down Expand Up @@ -74,7 +74,7 @@ public void onClick(DialogInterface dialog, int id) {

reloadAppsList();
}

@Override
protected void onResume() {
mRootShell = new RootUtil();
Expand All @@ -85,7 +85,13 @@ protected void onResume() {
public void installLibrary() {
String library = getApplicationInfo().nativeLibraryDir + File.separator + "librootcloak.so";

if (!mRootShell.isSU() || !new File(library).exists()) {
if (!mRootShell.isSU()) {
Toast.makeText(this, R.string.library_no_root, Toast.LENGTH_LONG).show();
finish();
return;
}

if (!new File(library).exists()) {
Toast.makeText(this, R.string.library_installation_failed, Toast.LENGTH_LONG).show();
finish();
return;
Expand Down Expand Up @@ -189,7 +195,7 @@ public boolean onPreferenceChange(
Set<String> newSetting = (Set<String>) newValue;
oldSetting.removeAll(newSetting);
mPrefs.edit().putStringSet("reset_native_root_detection_apps", oldSetting).apply();

Intent refreshApps = new Intent(Common.REFRESH_APPS_INTENT);
sendBroadcast(refreshApps);
return true;
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,6 @@
<string name="manage_keywords">Manage Keywords</string>
<string name="manage_commands">Manage Commands</string>
<string name="app_launcher_icon">App Launcher Icon</string>
<string name="library_no_root">Root permission denied</string>

</resources>