Skip to content

fix: tighten hybrid-device touch guards and pin Node version in CI #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devakesu merged 2 commits into from
Mar 6, 2026
Merged

fix: tighten hybrid-device touch guards and pin Node version in CI #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d5fea3
Initial plan
Copilot Mar 6, 2026
ce2714d
fix: apply review feedback — any-pointer guard, hybrid CSS fix, pin N…
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: '20'
node-version: '20.19.0'

- name: Install dependencies
run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions app/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ html {
text-rendering: optimizeLegibility;
}

/* Desktop-only scroll behavior — avoids killing iOS momentum / rubber-band scrolling */
@media (pointer: fine) {
/* Desktop-only scroll behavior — avoids killing iOS momentum / rubber-band scrolling on touch/hybrid devices */
@media (pointer: fine) and (not (any-pointer: coarse)) {
html {
scroll-behavior: smooth;
/* Improve mouse wheel scrolling smoothness */
Expand Down
9 changes: 7 additions & 2 deletions public/js/reactive-glow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,14 @@
);

// Skip scroll pulse effect on touch devices (causes jank during mobile scroll)
const isTouchDevice =
const hasAnyCoarsePointer =
typeof window.matchMedia === 'function' &&
window.matchMedia('(pointer: coarse)').matches;
window.matchMedia('(any-pointer: coarse)').matches;
const hasTouchPoints =
typeof navigator !== 'undefined' &&
typeof navigator.maxTouchPoints === 'number' &&
navigator.maxTouchPoints > 0;
const isTouchDevice = hasAnyCoarsePointer || hasTouchPoints;

// Scroll velocity → pulse strength (throttled with rAF)
if (!isTouchDevice) {
Expand Down