docs(agents): point Validation at the guard script instead of copying it#69
Conversation
Validation step 3 asserted every plugin.json has .skills == "skills/", long after the convention moved to omitting that field (skills are auto-discovered). Following the documented steps reported all 8 plugins broken while CI was green. The root cause is duplication: steps 1-4 hand-copied the checks that validate-manifests.sh already owns. That script's own header calls itself the single source of truth and says AGENTS.md documents it for local runs -- and line 61 already says the checks 'live in one place'. The copy contradicted both, and drifted. Replace steps 1-4 with the script CI actually runs, and record why, so the next edit doesn't reintroduce a copy. Steps for the spec check and actionlint are unchanged. Fixes #65 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai review |
|
✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Why
AGENTS.md's Validation step 3 told you to assert everyplugin.jsonhas.skills == "skills/". The convention moved to omitting that field (skills are auto-discovered), so following our own documented steps reports all 8 plugins broken while CI is green. A contributor who trusts the doc goes hunting for a problem that doesn't exist.The root cause isn't the stale line — it's duplication. Steps 1–4 hand-copied checks that
scripts/validate-manifests.shalready owns. That script's own header calls itself "the single source of truth for the checks CI runs" and says it is "documented in AGENTS.md for local runs … so the gate stays a single source of truth with no inline/doc drift". Line 61 of this very file already says the checks "live in one place". The copy contradicted both — and drifted, exactly as predicted.What
Replaces steps 1–4 with the one command CI actually runs, and records why, so the next edit doesn't reintroduce a copy. The spec-validation and
actionlintsteps are unchanged.Verified both directions on the same tree: the old documented snippet reports 8 failures;
./scripts/validate-manifests.shexits 0 — so the snippet was wrong, not the repo.Fixes #65