docs(scaffold): correct stale platform-policy citations#81
Conversation
The scaffold's comments are how a tenant author learns what the platform will do to their manifests, so a stale citation misleads exactly the reader who trusts it most. Two had drifted from the live policy set: - add-default-deny now generates three resources, not two: a plain networking.k8s.io/v1 NetworkPolicy lands alongside the deny-all and allow-dns CiliumNetworkPolicies. Note it, and why a CiliumNetworkPolicy alone still re-opens a path (Cilium unions the allow-sets across both kinds). - The admissibility gate claimed a CEL ValidatingPolicy was a future concern. Two ImageValidatingPolicy resources ship today and verify-app-images is Deny-mode over every ghcr.io/devantler-tech/* tenant image. State the real scope boundary instead: signature checks need a published signed digest, so they cannot run in an offline gate against a placeholder tag. Comment-only; no manifest or gate behaviour changes.
@codex review |
Readiness evidence at head
|
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Why
The scaffold's comments are how a tenant author learns what the platform will do to their manifests. Two of those comments had drifted from the live policy set, so the reader who trusts them most gets the wrong picture — including about the one policy that can reject their pod outright.
What
Corrects two stale citations. The default-deny note now reflects that three resources are generated, not two, and says why a CiliumNetworkPolicy alone is still enough to re-open a path. The admissibility gate no longer calls CEL image policies a future concern — they ship today and one is Deny-mode over every tenant image — and instead states the real reason the gate cannot cover them: signature checks need a published signed digest, which an offline gate against a placeholder tag can never satisfy.
Comment-only; no manifest or gate behaviour changes. Found while working the platform-lockstep theme of #6.
Part of #6