test(ci): exercise tenant SecretStore admission#85
Merged
Conversation
Contributor
Author
Readiness evidence at
|
| Admission case | Exit | Kyverno result | Evaluation |
|---|---|---|---|
Valid namespaced SecretStore, KSail-managed namespace, tenant service account |
0 | pass 1 / fail 0 | expected valid tenant request accepted |
ClusterSecretStore mutant, same tenant context |
1 | pass 0 / fail 1 | expected policy restrict-tenant-secret-stores / rule externalsecret-no-clustersecretstore denial |
| Same mutant in an unmanaged namespace | 0 | all zero / no match | intended policy scope preserved |
Same mutant applied by flux-system/kustomize-controller |
0 | all zero / excluded | intended platform carve-out preserved |
The PR remains draft while exact-head GitHub checks and an exact-head reviewer artifact complete.
Contributor
Author
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
devantler
marked this pull request as ready for review
July 19, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The template promises tenant manifests that are admissible on the live platform, but its policy-set smoke check did not model the namespace labels or reconciliation identity used by the high-severity SecretStore isolation rule. Unrelated policy passes could therefore leave that boundary untested.
What
restrict-tenant-secret-storesExternalSecret rule so aggregate results cannot mask it;ClusterSecretStoremutation is denied, and the unmanaged-namespace and platform-reconciler carve-outs remain intentional;Fixes #84
Part of #6