Skip to content

docs(template-sync): document APP_CLIENT_ID and external ci.yaml ownership#182

Merged
devantler merged 1 commit into
mainfrom
claude/template-sync-optin-docs
Jul 17, 2026
Merged

docs(template-sync): document APP_CLIENT_ID and external ci.yaml ownership#182
devantler merged 1 commit into
mainfrom
claude/template-sync-optin-docs

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Daily AI Engineer

Why

An adopter outside devantler-tech following the current opt-in doc would enable the weekly sync and have token creation fail: the reusable workflow needs the App's client ID as well as its key, but only the key was documented. The synced ci.yaml is also an empty aggregator outside the org's rulesets, which the docs didn't say.

What

Documents the full external opt-in triple (APP_CLIENT_ID variable + APP_PRIVATE_KEY secret + TEMPLATE_SYNC_ENABLED=true) and how external instances take ownership of ci.yaml. Doc-only; mirrors dotnet-template#292's merged wording.

…rship

The external opt-in was under-documented: the reusable workflow mints its
App token from the APP_CLIENT_ID variable + APP_PRIVATE_KEY secret, but
only the secret was named — an external adopter following the README
would enable the schedule and fail token creation. Also scope the
ci.yaml template-ownership claim to devantler-tech instances and
document how external instances take ownership. Mirrors the wording
shipped in dotnet-template#292.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Daily AI Engineer

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: f300719364

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Daily AI Engineer

Self-promotion readiness record (head f300719): doc/comment-only change with no exercisable runtime surface in-template (the opt-in path only runs in external instances) — per the contract's no-exercisable-surface carve-out the readiness rests on factual verification: the APP_CLIENT_ID claim was checked against devantler-tech/actions' reusable template-sync workflow source (client-id: ${{ vars.APP_CLIENT_ID }}), and the wording mirrors the merged dotnet-template#292. Pentad clear: green CI, 0 threads, CLEAN, Codex clean at this head (premerge absent = Codex lane), actionlint clean. Promoting and merging.

@devantler
devantler marked this pull request as ready for review July 17, 2026 11:08
@devantler
devantler requested a review from a team as a code owner July 17, 2026 11:08
@devantler
devantler merged commit e825804 into main Jul 17, 2026
11 checks passed
@devantler
devantler deleted the claude/template-sync-optin-docs branch July 17, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant