docs(agents): correct the Validation topology in go-template AGENTS.md#183
Draft
devantler wants to merge 2 commits into
Draft
docs(agents): correct the Validation topology in go-template AGENTS.md#183devantler wants to merge 2 commits into
devantler wants to merge 2 commits into
Conversation
AGENTS.md claimed a repository ruleset "Require workflows to pass before merging for Go" injects the archived devantler-tech/reusable-workflows validate-go-project workflow (go build/test/lint/dead-code/MegaLinter/coverage) on every PR and the merge queue. Verified live against a real .go-touching PR's check set (#163) and the repo's rulesets: no such ruleset exists, and no validate-go-project workflow runs on this template's CI at all. The real gates are CI - Required Checks (a trivial aggregator), Validate Scaffold, and the org CodeQL / zizmor / Dependency Review rulesets; the full Go gate runs in generated projects, not the template. Rewrite the Validation section and the two dependent references (toolchain-floor note and the Maintenance validate-before-PR line) to match, dropping the stale reusable-workflows reference. Fixes #181 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 702073cb62
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Correct three over-broad claims from the first pass: the template's CI is not free of Go build/test (the Validate Scaffold job builds and tests a renamed scaffold copy — there is just no dedicated lint/coverage gate); Validate Scaffold is pull_request-only, so the merge queue is gated by ci.yaml's CI - Required Checks, not Validate Scaffold; and generated projects gate Go via org-injected ruleset workflows (devantler-tech) or a manually-replaced ci.yaml (outside the org), not via the scaffolded ci.yaml aggregator. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AGENTS.md described a Go CI gate that does not exist — a "Require workflows to pass before merging for Go" ruleset injecting a
validate-go-projectworkflow from the archivedreusable-workflowsrepo. Agents and contributors follow AGENTS.md as canonical, so a wrong validation topology misleads every future change here.What
Verified the live topology against a real
.go-touching PR's check set and the repo's rulesets, then rewrote the Validation section (and its two dependent references) to describe the gates that actually run —CI - Required Checks,Validate Scaffold, and the org CodeQL/zizmor/Dependency-Review rulesets — and to note the full Go gate runs in generated projects, not this template. Docs-only.Fixes #181