fix(release): treat type!: commits as breaking#184
Closed
devantler wants to merge 1 commit into
Closed
Conversation
semantic-release's default preset recognises only a `BREAKING CHANGE:` footer, so `feat!:` produced NO release at all and a breaking change shipped unversioned. The org's commit-message ruleset explicitly permits the bang. Only the bang forms change; existing release rules are preserved. Part of devantler-tech/actions#653
Contributor
Author
Closing and redoing: this commit was authored via the GitHub API with a PAT, so it is unsigned, and this repo requires signed commits — the PR is unmergeable as-is. Reopening shortly with a locally-signed commit. The diff itself was correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A bang-style breaking commit —
feat!: …— currently produces no release at all in this repo.Not a wrong version: no release, so a breaking change ships unversioned and nobody downstream learns
the API broke.
semantic-release's default preset only recognises a
BREAKING CHANGE:footer, while the org'scommit-message ruleset explicitly permits the bang — so contributors are invited to write exactly
the form that silently does nothing.
What
Makes
type!:cut a major release. Nothing else changes:feat:→ minor,fix:→ patch,docs:/chore:/ci:→ no release, and theBREAKING CHANGE:footer keeps working. Any existingrelease rules in this repo are preserved.
Safe to merge now — this repo has no unreleased bang commits, so nothing jumps a major on merge.
Part of devantler-tech/actions#653