refactor(provisioner): remove reflection from multi-provisioner tests

[devantler]

🤖 Generated by the Daily AI Engineer

Why

The multi-provisioner tests inspected the Kind provisioner's private fields via reflection, so a routine rename or re-layout of those internals would silently break the tests — brittle coupling to another package's internals.

What

Adds a small injectable Kind-factory seam so the tests assert the config and kubeconfig arguments the minimal path hands to the factory directly, with no reflection. Production behaviour is unchanged (it always uses the real Kind factory). Test-only refactor — no runtime behaviour change, no flag needed.

Fixes #6049

[devantler]

🤖 Generated by the Daily AI Engineer

Readiness / tried-as-a-user (test-refactor): the exercisable surface of this change is the test suite itself, and I exercised it directly:

• go build ./..., go vet, and golangci-lint run on the package are clean.
• Full pkg/svc/provisioner/cluster suite: 74/74 pass with the reflection removed.
• RED/GREEN on the seam's teeth: temporarily broke the source the two rewritten tests guard — mangled the kubeconfig forwarded to the factory (/tmp/…-kind-kubeconfig → …-RED) and the kindConfig APIVersion (kind.x-k8s.io/v1alpha4 → BROKEN). Both spy-based tests failed on exactly those assertions; restoring the source returned them to green. So the argument assertions genuinely have teeth without reflecting over the provisioner's internals.

Production is unchanged — kindProvisionerFactory defaults to kindprovisioner.CreateProvisioner, and the existing Docker-error tests still drive the real factory.

[github-actions]

✅MegaLinter analysis: Success

✅ Linters with no issues

actionlint, bash-exec, git_diff, hadolint, jscpd, jsonlint, lychee, markdown-table-formatter, markdownlint, prettier, prettier, shellcheck, shfmt, stylelint, syft, trivy-sbom, trufflehog, v8r, v8r, yamllint

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Show us your support by starring ⭐ the repository

[github-code-quality]

Code Coverage Overview

Languages: Go

Go / code-coverage/go

The overall coverage in the claude/multi-provisi... branch remains at 67%, unchanged from the main branch.

Show a code coverage summary of the most impacted files.

File	main 3ff2d8c	claude/multi-provisi... 47e0deb	+/-
pkg/svc/provisi...base/bringup.go	92%	90%	-2%
pkg/client/reconciler/poll.go	80%	84%	+4%

---

_{Code Coverage is in Public Preview. Learn more and provide us with your feedback.}

[devantler]

🤖 Generated by the Daily AI Engineer

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 47e0debb21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[devantler]

🤖 Generated by the Daily AI Engineer

@coderabbitai review

[coderabbitai]

@devantler I’ll review the changes in #6219.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a package-level Kind provisioner factory seam that defaults to the existing constructor and can be replaced by tests with a restore closure. Updates Vanilla-Kind tests to capture kubeconfig and v1alpha4.Cluster arguments directly, removing reflection and parallel execution. Assertions now validate the forwarded kubeconfig path and generated API version, kind, and name.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The changes satisfy #6049 by adding a private Kind factory seam and replacing reflection-based assertions with direct argument checks.
Out of Scope Changes check	✅ Passed	The diff appears limited to the requested testability refactor and related test updates, with no clear out-of-scope work.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately summarizes the main change: removing reflection from multi-provisioner tests.
Description check	✅ Passed	The description directly matches the refactor and explains the new Kind factory seam and test changes.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devantler]

🤖 Generated by the Daily AI Engineer

Readiness record (self-promotion @47e0debb)

• Programmatically tested — CI green (57 success / 12 skipped), premerge checks green (✅5), 0 unresolved threads, no reviewer body findings, CLEAN vs base. RED/GREEN proven: breaking APIVersion and the kubeconfig forward each failed exactly the two new factory-argument assertions; restoring returned them to green. 74/74 package tests; golangci / vet / gofmt clean.
• Reviewed — Codex green at head: Didn't find any major issues, reviewed commit 47e0debb21.
• Tried and evaluated as a user — this change's only runtime surface is the test suite itself, which was exercised in full; the injectable factory seam follows the repo's sanctioned DI pattern and the production path is unchanged.

Promoting and merging.