Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/docker-in-docker/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {
"version": "${templateOption:dockerVersion}",
"enableNonRootDocker": "${templateOption:enableNonRootDocker}",
"moby": "${templateOption:moby}"
}
}
Expand Down
1 change: 0 additions & 1 deletion src/docker-in-docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ Create child containers _inside_ a container, independent from the host's docker
| upgradePackages | Upgrade OS packages? | boolean | false |
| dockerVersion | Select or enter a Docker/Moby CLI version. (Availability can vary by OS version.) | string | latest |
| moby | Install OSS Moby build instead of Docker CE | boolean | true |
| enableNonRootDocker | Enable non-root user to access Docker in container? | boolean | true |

## Using this template

Expand Down
7 changes: 1 addition & 6 deletions src/docker-in-docker/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "docker-in-docker",
"version": "1.3.2",
"version": "1.3.3",
"name": "Docker in Docker",
"description": "Create child containers _inside_ a container, independent from the host's docker instance. Installs Docker extension in the container along with needed CLIs.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/docker-in-docker",
Expand Down Expand Up @@ -31,11 +31,6 @@
"type": "boolean",
"default": "true",
"description": "Install OSS Moby build instead of Docker CE"
},
"enableNonRootDocker": {
"type": "boolean",
"description": "Enable non-root user to access Docker in container?",
"default": "true"
}
},
"platforms": ["Any"],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {
"enableNonRootDocker": "true",
"moby": "true"
},
"ghcr.io/devcontainers/features/kubectl-helm-minikube:1": {
Expand Down
2 changes: 1 addition & 1 deletion src/kubernetes-helm-minikube/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "kubernetes-helm-minikube",
"version": "2.2.2",
"version": "2.2.3",
"name": "Kubernetes - Minikube-in-Docker",
"description": "Access an embedded minikube instance from inside a dev container. Includes kubectl, Helm, minikube, and the Docker.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/kubernetes-helm-minikube",
Expand Down
2 changes: 1 addition & 1 deletion test/kubernetes-helm-minikube/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ checkExtension "ms-azuretools.vscode-docker"
checkExtension "ms-kubernetes-tools.vscode-kubernetes-tools"
check "docker" docker ps -a
check "kubectl" kubectl version --client
check "helm" helm version --client
check "helm" helm version --short
check "minikube start" minikube start
check "minikube remove" minikube delete
docker image prune -a -f
Expand Down
Loading