This repository was archived by the owner on Jan 10, 2024. It is now read-only.
Extended base class and fixed fatal errors#37
Open
DaSpors wants to merge 3 commits intodeveloperforce:masterfrom
Open
Extended base class and fixed fatal errors#37DaSpors wants to merge 3 commits intodeveloperforce:masterfrom
DaSpors wants to merge 3 commits intodeveloperforce:masterfrom
Conversation
Added ContinueSession to avoid multiple login calls
Contributor
|
Looks good - thanks! One minor nit - function names should start with lower case, so could you change ContinueSession and RefreshToken to continueSession and refreshToken respectively? Also, we need a contributor license agreement (CLA, very similar to Apache projects) to accept substantial contributions. Could you fill out the CLA doc, scan it, and send it to me at ppatterson (at) salesforce (dot) com? |
|
RefreshToken() adds an explicit dependency on curl, and uses REST API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We extended the SOAP base class with a method to allow re-use of authorized sessions.
Additionally the sessionHeader was added to the SOAP header without check for existance, so there was an empty header thus beeing invalid. This has been fixed.